Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add witness count #5890

Merged
merged 3 commits into from
Jan 31, 2023
Merged

metrics: add witness count #5890

merged 3 commits into from
Jan 31, 2023

Conversation

ethercflow
Copy link
Member

@ethercflow ethercflow commented Jan 31, 2023 •
edited
Loading

ref #5568

Signed-off-by: Wenbo Zhang [email protected]

What problem does this PR solve?

image

Issue Number: ref #5568

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

None

@ethercflow
metrics: add witness count
d11a5b7 
ref tikv#5568

Signed-off-by: Wenbo Zhang <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 31, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 31, 2023
@ti-chi-bot ti-chi-bot requested review from nolouch and rleungx January 31, 2023 07:56
@codecov
Copy link

codecov bot commented Jan 31, 2023 •
edited
Loading

Codecov Report

Base: 75.72% // Head: 75.87% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (9775451) compared to base (01b2fb5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5890      +/-   ##
==========================================
+ Coverage   75.72%   75.87%   +0.15%     
==========================================
  Files         342      342              
  Lines       34847    34850       +3     
==========================================
+ Hits        26387    26444      +57     
+ Misses       6220     6175      -45     
+ Partials     2240     2231       -9
Flag Coverage Δ
unittests 75.87% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/statistics/region_collection.go 97.52% <100.00%> (+0.03%) ⬆️
pkg/storage/endpoint/meta.go 63.63% <0.00%> (-6.82%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
pkg/btree/btree_generic.go 86.34% <0.00%> (-0.93%) ⬇️
server/cluster/cluster.go 81.67% <0.00%> (-0.69%) ⬇️
pkg/member/member.go 63.68% <0.00%> (-0.53%) ⬇️
server/handler.go 52.88% <0.00%> (-0.39%) ⬇️
server/cluster/unsafe_recovery_controller.go 78.70% <0.00%> (-0.35%) ⬇️
client/client.go 70.79% <0.00%> (+0.10%) ⬆️
server/cluster/coordinator.go 72.34% <0.00%> (+0.37%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Connor1996
Connor1996 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 31, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 31, 2023
@bufferflies
Copy link
Contributor

how about add some picture about this changes ?

@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d11a5b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 31, 2023
@ti-chi-bot
Copy link
Member

@ethercflow: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4f4c973 into tikv:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ethercflow @ti-chi-bot @bufferflies @Connor1996 @lhy1024